Fix blocks_kitchen_sink and streaming_stt demos #4699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freddyaboulton
added
docs/website
|
馃帀 The demo notebooks match the run.py files! 馃帀 |
freddyaboulton
commented
Jun 27, 2023
website/homepage/upload_demos.py
Outdated
| --- | ||
| """ | ||
| readme.open("w").write(textwrap.dedent(readme_content)) | ||
| --- |
There was a problem hiding this comment.
Moving the text here otherwise the indented lines will mess up the README in the deployed space. textwrap.dedent is not working as expected so had to resort to this.
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4699-all-demos |
freddyaboulton
commented
Jun 27, 2023
demo/generate_notebooks.py
Outdated
| @@ -26,7 +26,7 @@ def git_tracked(demo, file): | |||
| """ | |||
|
|
|||
| files = os.listdir(os.path.join(GRADIO_DEMO_DIR, demo)) | |||
| skip = ["run.py", "run.ipynb", "setup.sh", ".gitignore", "requirements.txt", "DESCRIPTION.md", "screenshot.png", "screenshot.gif"] | |||
| skip = ["run.py", "run.ipynb", "setup.sh", ".gitignore", "requirements.txt", "DESCRIPTION.md", "screenshot.png", "screenshot.gif", "README.json"] | |||
There was a problem hiding this comment.
Should not be present in the colab
freddyaboulton
force-pushed
the
fix-more-demos
branch
from
6ff2f6b
to
2c7857f
Compare
Could we just have a That being said, specifically for this demo |
|
Might be easiest to just delete then! |
|
Yeah sounds good, we can revisit if there are more important demos that require specific readmes |
|
LGTM thanks @freddyaboulton |
abidlabs
approved these changes
Jun 28, 2023
|
Thank you @abidlabs 馃槃 |
dawoodkhan82
pushed a commit
that referenced
this pull request
Jun 28, 2023
* Add code * Add json file * Remove streaming_stt demo * Undo generate_notebooks * Add blocks_kitchen_sink
dawoodkhan82
added a commit
that referenced
this pull request
Jun 28, 2023
* playwright tests for chatbot * more tests * changelog * Update CHANGELOG.md * fix upload file delay (#4661) * fix * changes * changes --------- Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * Forward `tqdm` constructor arguments to `Progress` component (#4475) * Forward tqdm constructor arguments to Progress component Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com> * lint * reorder args * added tests --------- Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * Remove cleared_value (#4685) * Remove cleared_value * CHANGELOG * Add requirements.txt to dialogpt demo (#4686) * Add requirements.txt * Update demo notebook * Add torch * remove streaming demo + more tests * Fix blocks_kitchen_sink and streaming_stt demos (#4699) * Add code * Add json file * Remove streaming_stt demo * Undo generate_notebooks * Add blocks_kitchen_sink * fix tests * Update js/app/test/chatbot_multimodal.spec.ts Co-authored-by: pngwn <hello@pngwn.io> * Update js/app/test/chatbot_multimodal.spec.ts Co-authored-by: pngwn <hello@pngwn.io> * Update js/app/test/chatbot_multimodal.spec.ts Co-authored-by: pngwn <hello@pngwn.io> * Update js/app/test/chatbot_multimodal.spec.ts Co-authored-by: pngwn <hello@pngwn.io> * Update js/app/test/chatbot_multimodal.spec.ts Co-authored-by: pngwn <hello@pngwn.io> * Update js/app/test/chatbot_multimodal.spec.ts Co-authored-by: pngwn <hello@pngwn.io> * Update js/app/test/chatbot_multimodal.spec.ts Co-authored-by: pngwn <hello@pngwn.io> * Update js/app/test/chatbot_multimodal.spec.ts Co-authored-by: pngwn <hello@pngwn.io> * Update js/app/test/chatbot_multimodal.spec.ts Co-authored-by: pngwn <hello@pngwn.io> * update notebook * remove debug * remove debug --------- Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com> Co-authored-by: aliabid94 <aabid94@gmail.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co> Co-authored-by: Ilya Trushkin <ilya.trushkin@intel.com> Co-authored-by: Freddy Boulton <alfonsoboulton@gmail.com> Co-authored-by: pngwn <hello@pngwn.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The streaming_stt demo is broken because spaces default python version is 3.10 now but
deepspeech==0.9.3is only available up to python 3.9. EDIT: We're just going to delete the demo since deepspeech is not maintained.The fix I'm proposing is that we have an optionalREADME.jsonin the demo dir with any values the deployed space should have in the readme. In the case of streaming_stt, this would be{"python_version": "'3.9'"}Deployed the following demos with this script to test:https://huggingface.co/spaces/freddyaboulton/streaming_stthttps://huggingface.co/spaces/freddyaboulton/blocks_inputshttps://huggingface.co/spaces/freddyaboulton/calculatorblocks_kitchen_sink is not expected to work outside of
all_demosso I deleted the space and making changes so that it does not get deployed again.馃幆 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests & Changelog
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.shUnless the pull request is labeled with the "no-changelog-update" label by a maintainer of the repo, all pull requests must update the changelog located in
CHANGELOG.md:Please add a brief summary of the change to the Upcoming Release section of the
CHANGELOG.mdfile and includea link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)".