Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scroll to top when api clicked in spaces #4714

Merged
merged 5 commits into from Jun 29, 2023
Merged

scroll to top when api clicked in spaces #4714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
074975a
scroll to top when api clicked in spaces
pngwn Jun 28, 2023
3a69adb
changelog
pngwn Jun 28, 2023
4bfa8d4
Merge branch 'main' into 4682-scroll-api
abidlabs Jun 29, 2023
22d4851
Merge branch 'main' into 4682-scroll-api
abidlabs Jun 29, 2023
a7ca3ac
Merge branch 'main' into 4682-scroll-api
pngwn Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -30,6 +30,7 @@
- When an error modal is shown in spaces, ensure we scroll to the top so it can be seen by [@pngwn](https://github.com/pngwn) in [PR 4712](https://github.com/gradio-app/gradio/pull/4712)
- Update depedencies by [@pngwn](https://github.com/pngwn) in [PR 4675](https://github.com/gradio-app/gradio/pull/4675)
- Fixes `gr.Dropdown` being cutoff at the bottom by [@abidlabs](https://github.com/abidlabs) in [PR 4691](https://github.com/gradio-app/gradio/pull/4691).
- Scroll top when clicking "View API" in spaces by [@pngwn](https://github.com/pngwn) in [PR 4714](https://github.com/gradio-app/gradio/pull/4714)
- Fix bug where `show_label` was hiding the entire component for `gr.Label` by [@freddyaboulton](https://github.com/freddyaboulton) in [PR 4713](https://github.com/gradio-app/gradio/pull/4713)

## Other Changes:
Expand Down
3 changes: 3 additions & 0 deletions js/app/src/api_docs/ApiDocs.svelte
View file
Open in desktop
Expand Up @@ -132,6 +132,9 @@

onMount(() => {
document.body.style.overflow = "hidden";
if ("parentIFrame" in window) {
window.parentIFrame?.scrollTo(0, 0);
}
return () => {
document.body.style.overflow = "auto";
};
Expand Down