Mobile queue fixes #4742
Mobile queue fixes #4742
Conversation
* create abstract toast component for info/warning/error * add icons * add light mode theming * add theme mode check and dark mode styles * update theme_mode on update * clean up render of toast content * replace dynamic css vars with toast type css selectors * tweak colours * change error pill border colour to align with toasts * formatting * fix failed test * rename icon files and clean up css
|
Working on testing this |
| const SHOW_DUPLICATE_MESSAGE_ON_ETA = 15; | ||
| const SHOW_MOBILE_QUEUE_WARNING_ON_ETA = 10; |
There was a problem hiding this comment.
Perhaps also set this to 15 seconds like SHOW_DUPLICATE_MESSAGE_ON_ETA so that we have a consistent definition of a "long waiting time" that we can communicate to users
There was a problem hiding this comment.
I chose 10 seconds specifically because that's how long it seems iPhones break a websocket connection on low power mode. I don't think there's any need for these to match
There was a problem hiding this comment.
That should probably be documented in a comment near the constant :)
|
Very nice @aliabid94! Can confirm that I see this warning modal when I initiate the job:
(though only with queuing enabled, which I think is fine) And I see this when I switch tabs. (Btw on my iPhone, I only see this if I set it to low power mode, otherwise the connection doesn't break):
|
|
Maybe this is part of the scroll_to_output problem on spaces but on the deployed demo the warning gets automatically closed IMG_6055.MOV |
|
Hmm @freddyaboulton it's working fine for me on iPhone (tested on Chrome and Safari)
Are you on iPhone? |
|
yes - iphone and on safari 🤔 I have an ancient iphone 10 though. let me try again. |
There was a problem hiding this comment.
Modal stopped disappearing for me @aliabid94 ! Thanks for the fix
CHANGELOG.md
Outdated
| @@ -52,6 +52,7 @@ | |||
| - Better errors when you define two Blocks and reference components in one Blocks from the events in the other Blocks [@abidlabs](https://github.com/abidlabs) in [PR 4738](https://github.com/gradio-app/gradio/pull/4738). | |||
| - Better message when share link is not created by [@abidlabs](https://github.com/abidlabs) in [PR 4773](https://github.com/gradio-app/gradio/pull/4773). | |||
| - Improve accessibility around selected images in gr.Gallery component by [@hannahblair](https://github.com/hannahblair) in [PR 4790](https://github.com/gradio-app/gradio/pull/4790) | |||
| - Warning on mobile that if a user leaves the tab, websocket connection may break. On broken connection, tries to rejoin queue and displays error conveying connection broke. By [@aliabid94](https://github.com/aliabid94) in [PR 4742](https://github.com/gradio-app/gradio/pull/4742) | |||
There was a problem hiding this comment.
Let's move this to the correct changelog release section!
| const SHOW_DUPLICATE_MESSAGE_ON_ETA = 15; | ||
| const SHOW_MOBILE_QUEUE_WARNING_ON_ETA = 10; |
Closes: #2075