New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better message when share link is not created #4773
Conversation
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4773-all-demos |
Chromatic build successful 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any good way to test this? Btw earlier I was running main, when I couldn't launch a share link from a hospital network with a firewall, I didn't get any error message at all, it just hanged.
You could do the following:
and you should see the message printed
I think this is a different issue. Not tackled by this PR |
Might be fixed by adding a suitable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @abidlabs
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Thanks @freddyaboulton! |
Hello.. my gradio application successfully downloads the frpc file but doesn't create any sharing link and just hangs. I tried switching the wifi off after deleting the frpc file, only then it says that can't create a share link. |
If a user sets
share=True
, and an antivirus blocks the download of the FRP binary, the message is a little cryptic, as can be seen by issues: #4548 and #3230.Here's the current message (which doesn't make sense as it references a non-existent file):
Here's the new, more instructive message including a workaround:
Closes: #4548