Fix: Dispatched errors from inside components bubble to top #4786
Conversation
js/app/src/Blocks.svelte
Outdated
| @@ -417,6 +418,19 @@ | |||
| handled_dependencies[i].push(id); | |||
| }); | |||
| }); | |||
| if (!attached_error_listeners) { | |||
There was a problem hiding this comment.
Apparently handle_mount runs multiple times, so I had to use attached_error_listeners to make sure I only attach error listeners once. Could not figure out why handle mount runs multiple times.
There was a problem hiding this comment.
That's by design, because onMount from child components will run at different times with different elements being ready at different points. So we need to allow this onMount callback to rerun as many times as is necessary to ensure that we handle the mounting of all child components, that said I wanna reword this when I refactor this code shortly.
There was a problem hiding this comment.
So onMount runs every time a child is added?
There was a problem hiding this comment.
Yeah. That's why we keep track of which dependencies have already been handled in this block, so we don't add additional listeners for them after we have done it once. We track them via their ids.
There was a problem hiding this comment.
ok, did something similar
There was a problem hiding this comment.
attached_error_listeners is an array of ids now
aliabid94
changed the title
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4786-all-demos |
|
Chromatic build successful 🎉 |
js/app/src/Blocks.svelte
Outdated
| attached_error_listeners = true; | ||
| components.forEach((c) => { | ||
| if (c.instance) { | ||
| c.instance.$on("error", (event_data: any) => { | ||
| messages = [ | ||
| new_message(event_data.detail, -1, "error"), | ||
| ...messages | ||
| ]; | ||
| }); | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
Couldn't this potentially only attach a single listener when there could be multiple?
There was a problem hiding this comment.
So instead of only running this once, every time we should track which components have an error listener attached, and add to the ones that don't, correct?
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dispatch("error")stopped working during an error modal refactor, since we now handle errors at the top. Fixed.