Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the expired image link used in theme builder #4944

Merged
merged 8 commits into from Jul 17, 2023

Conversation

deepkyu
Copy link
Contributor

@deepkyu deepkyu commented Jul 17, 2023

Description

Please include a concise summary, in clear English, of the changes in this pull request. If it closes an issue, please mention it here.

Closes: #4941

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests & Changelog

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

  3. Unless the pull request is labeled with the "no-changelog-update" label by a maintainer of the repo, all pull requests must update the changelog located in CHANGELOG.md:

Please add a brief summary of the change to the Upcoming Release section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by [@myusername](link-to-your-github-profile) in [PR 11111](https://github.com/gradio-app/gradio/pull/11111)".

@vercel
Copy link

vercel bot commented Jul 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
gradio ✅ Ready (Inspect) Visit Preview Jul 17, 2023 3:37pm

@gradio-pr-bot
Copy link
Contributor

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4944-all-demos


You can install the changes in this PR by running:

pip install https://gradio-builds.s3.amazonaws.com/6d40cdc7c516434d498d6b1bf129cfaa1d5a7eb3/gradio-3.36.1-py3-none-any.whl

gradio/themes/app.py Outdated Show resolved Hide resolved
gradio/themes/app.py Outdated Show resolved Hide resolved
deepkyu and others added 2 commits July 18, 2023 00:10
change the image link same as the original one

Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
change the image link same as the original one

Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
@deepkyu deepkyu changed the title Fix the expired image link used in theme builder [WIP] Fix the expired image link used in theme builder Jul 17, 2023
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jul 17, 2023

🎉 The demo notebooks match the run.py files! 🎉

@deepkyu deepkyu changed the title [WIP] Fix the expired image link used in theme builder Fix the expired image link used in theme builder Jul 17, 2023
@deepkyu
Copy link
Contributor Author

deepkyu commented Jul 17, 2023

Now it seems that gradio repository doesn't contain the following image links at all:

Those are replaced with this link, which is a current header image in gradio.app.

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deepkyu !!

@abidlabs
Copy link
Member

LGTM thanks folks

@abidlabs abidlabs merged commit e6cf145 into gradio-app:main Jul 17, 2023
13 checks passed
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jul 17, 2023

🎉 Chromatic build completed!

There are 0 visual changes to review.
There are 0 failed tests to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spaces auto-generated from push_to_hub raises an error
4 participants