New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cropped videos CSS bug #4946
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4946-all-demos You can install the changes in this PR by running: pip install https://gradio-builds.s3.amazonaws.com/181c6721b6c57eb533d4c8e781aeda75917f63b8/gradio-3.37.0-py3-none-any.whl |
🎉 Chromatic build completed! There are 25 visual changes to review. |
…p/gradio into fix-cropped-videos-bug
…p/gradio into fix-cropped-videos-bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for taking care of this @hannahblair!
Description
This PR fixes an issue where the width and height aren't properly used within the video component. Also adds accessibility tweaks but the timeline in our video definitely needs to be revisited (the
<progress />
element), as we can't control that via the keyboard nor does it have the appropriate aria role applied.Closes: #4895
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests & Changelog
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh
Unless the pull request is labeled with the "no-changelog-update" label by a maintainer of the repo, all pull requests must update the changelog located in
CHANGELOG.md
:Please add a brief summary of the change to the Upcoming Release section of the
CHANGELOG.md
file and includea link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)
in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)
".