Run pyright on components directory #4948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4948-all-demos You can install the changes in this PR by running: pip install https://gradio-builds.s3.amazonaws.com/181c6721b6c57eb533d4c8e781aeda75917f63b8/gradio-3.37.0-py3-none-any.whl |
freddyaboulton
changed the title
freddyaboulton
force-pushed
the
apply-pyright-components
branch
from
a946ccf
to
84a96f4
Compare
|
🎉 Chromatic build completed! There are 24 visual changes to review. |
freddyaboulton
commented
Jul 17, 2023
| @@ -76,6 +76,10 @@ include = [ | |||
| "/requirements.txt", | |||
| ] | |||
|
|
|||
| [tool.pyright] | |||
| include = ["gradio/**/*.py"] | |||
| exclude = ["gradio/themes/"] | |||
There was a problem hiding this comment.
Will be pretty hard to type themes given the dynamic nature of all the theme props.
freddyaboulton
commented
Jul 17, 2023
| @@ -415,10 +415,10 @@ def postprocess(self, y: pd.DataFrame | dict | None) -> dict[str, str] | None: | |||
| tooltip=self.tooltip, | |||
| x_title=self.x_title, | |||
| y_title=self.y_title, | |||
| color_legend_title=self.color_legend_title, | |||
| color_legend_position=self.color_legend_position, | |||
| color_legend_title=self.color_legend_title, # type: ignore | |||
There was a problem hiding this comment.
I'm not sure why pyright is inferring these as str instead of Literal could be a bug
freddyaboulton
commented
Jul 17, 2023
| @@ -76,6 +76,10 @@ include = [ | |||
| "/requirements.txt", | |||
| ] | |||
|
|
|||
| [tool.pyright] | |||
| include = ["gradio/**/*.py"] | |||
There was a problem hiding this comment.
This should catch all python files in the package
freddyaboulton
requested review from
abidlabs,
aliabid94,
aliabd,
dawoodkhan82,
pngwn and
hannahblair
|
LGTM @freddyaboulton nice catch! |
abidlabs
approved these changes
Jul 18, 2023
freddyaboulton
changed the title
|
Thanks @abidlabs !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pyright command is not recursive so
componentsdirectory is not checked. Will fix after release.🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests & Changelog
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.shUnless the pull request is labeled with the "no-changelog-update" label by a maintainer of the repo, all pull requests must update the changelog located in
CHANGELOG.md:Please add a brief summary of the change to the Upcoming Release section of the
CHANGELOG.mdfile and includea link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)".