New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add css variable for controlling chatbot user message border accent #4989
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4989-all-demos You can install the changes in this PR by running: pip install https://gradio-builds.s3.amazonaws.com/f8e5bfa2d4b3950d2e51e25c040a08163303befd/gradio-3.37.0-py3-none-any.whl |
…b.com/gradio-app/gradio into add-chatbot-user-message-border-color
🎉 Chromatic build completed! There are 27 visual changes to review. |
Tested all of our built-in themes. Looks good @freddyaboulton! |
cc @gary149 |
Thanks @abidlabs !! |
Nice! |
Description
We got some feedback that the border color of user messages in the default theme is a bit hash.
Added
chatbot_user_message_border_color_accent
andchatbot_user_message_border_color_accent_dark
variables to the theme class to control this. Defaults toborder_color_accent
so there shouldn't be any noticeable changes except for default theme.Before
After
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests & Changelog
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh
Unless the pull request is labeled with the "no-changelog-update" label by a maintainer of the repo, all pull requests must update the changelog located in
CHANGELOG.md
:Please add a brief summary of the change to the Upcoming Release section of the
CHANGELOG.md
file and includea link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)
in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)
".