Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Add download button for audio"" #4993

Merged
merged 5 commits into from Jul 22, 2023

Conversation

abidlabs
Copy link
Member

@abidlabs abidlabs commented Jul 21, 2023

This should be merged in after the changesets have been reformatted

@vercel
Copy link

vercel bot commented Jul 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
gradio ✅ Ready (Inspect) Visit Preview Jul 22, 2023 0:13am

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jul 21, 2023

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4993-all-demos


You can install the changes in this PR by running:

pip install https://gradio-builds.s3.amazonaws.com/62306d9ed1b6bde0d6965be63c8a3a227d9ddb2e/gradio-3.38.0-py3-none-any.whl

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jul 22, 2023

🎉 Chromatic build completed!

There are 0 visual changes to review.
There are 0 failed tests to fix.

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jul 22, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/app minor
@gradio/audio minor
gradio minor

With the following changelog entry.

Bringing back the "Add download button for audio" PR by @leuryr.

⚠️ The changeset file for this pull request has been modified manually, so the changeset generation bot has been disabled. To go back into automatic mode, delete the changeset file.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member Author

Finally merging this in, thanks again @leuryr!

@abidlabs abidlabs merged commit dc07a9f into main Jul 22, 2023
14 of 15 checks passed
@abidlabs abidlabs deleted the revert-4992-revert-4977-4087-audio-download-button branch July 22, 2023 00:20
@pngwn pngwn mentioned this pull request Jul 22, 2023
@leuryr
Copy link
Contributor

leuryr commented Jul 23, 2023

Awesome @abidlabs ! Thanks for the opportunity to get involved. Looking forward to making other contributions in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants