Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure gradio_client is backwards compatible with gradio==3.24.1 #5061

Merged
merged 10 commits into from Aug 2, 2023

Conversation

abidlabs
Copy link
Member

@abidlabs abidlabs commented Aug 1, 2023

As discussed internally, some of the changes to the client were not fully backwards compatible, which broke older versions of gradio if they were using later versions of the client. This fixes that, at least for gradio==3.24.1 (I have not tested other versions of gradio).

To test:

  1. Install gradio==3.24.1
  2. Install the latest version of gradio_client from pypi
  3. Run any Gradio app (it will not work)
  4. Install gradio_client from this branch
  5. It should work

@vercel
Copy link

vercel bot commented Aug 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
gradio ✅ Ready (Inspect) Visit Preview Aug 2, 2023 4:51pm

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Aug 1, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
gradio_client patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Ensure gradio_client is backwards compatible with gradio==3.24.1

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Aug 1, 2023

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-5061-all-demos


You can install the changes in this PR by running:

pip install https://gradio-builds.s3.amazonaws.com/55b00b6da2e4a7e7f2bf4b0f088e74f3eeca9d6b/gradio-3.39.0-py3-none-any.whl

@abidlabs abidlabs changed the title Fix gradio_client backwards compatibility Fix gradio_client backwards compatibility for gradio==3.24.1 Aug 1, 2023
@abidlabs abidlabs changed the title Fix gradio_client backwards compatibility for gradio==3.24.1 Ensure gradio_client is backwards compatible with gradio==3.24.1 Aug 1, 2023
@abidlabs abidlabs added the v: patch A change that requires a patch release label Aug 1, 2023
@abidlabs abidlabs marked this pull request as ready for review August 1, 2023 20:33
@freddyaboulton
Copy link
Collaborator

I think we're going to do a hard pin of gradio_client in gradio requirements instead

@abidlabs
Copy link
Member Author

abidlabs commented Aug 2, 2023

We should do both @freddyaboulton -- make this fix to address older versions of gradio while also pinning gradio_client going forward (I'll add the pin to this PR)

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Aug 2, 2023

🎉 Chromatic build completed!

There are 0 visual changes to review.
There are 0 failed tests to fix.

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abidlabs !

@abidlabs
Copy link
Member Author

abidlabs commented Aug 2, 2023

Appreciate the review @freddyaboulton

@abidlabs abidlabs merged commit 136adc9 into main Aug 2, 2023
12 checks passed
@abidlabs abidlabs deleted the client-bc branch August 2, 2023 22:06
@pngwn pngwn mentioned this pull request Aug 2, 2023
@pngwn
Copy link
Member

pngwn commented Aug 14, 2023

The hard pin needs to be updated in CI because the requirements get updated every time we make a release. i'll find that and take care of it.

@freddyaboulton
Copy link
Collaborator

Thanks @pngwn !

@pngwn
Copy link
Member

pngwn commented Aug 14, 2023

#5222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: fix A change that implements a fix v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants