Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the images in the theme builder to use permanent URI #5188

Merged
merged 3 commits into from Aug 11, 2023
Merged

Fix the images in the theme builder to use permanent URI #5188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6b1f26
themes-header-image
abidlabs Aug 11, 2023
e927e12
add changeset
gradio-pr-bot Aug 11, 2023
f0bfad5
add changeset
gradio-pr-bot Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/light-mice-bake.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
"gradio": patch
---

feat:Fix the images in the theme builder to use permanent URI
4 changes: 2 additions & 2 deletions gradio/themes/app.py
View file
Open in desktop
Expand Up @@ -63,7 +63,7 @@
check = gr.Checkbox(label="Go")
with gr.Column(variant="panel", scale=2):
img = gr.Image(
"https://raw.githubusercontent.com/gradio-app/gradio/main/js/_website/src/assets/img/header-image.jpg",
"https://gradio-static-files.s3.us-west-2.amazonaws.com/header-image.jpg",
label="Image",
).style(height=320)
with gr.Row():
Expand All @@ -74,7 +74,7 @@

def go(*args):
time.sleep(3)
return "https://raw.githubusercontent.com/gradio-app/gradio/main/js/_website/src/assets/img/header-image.jpg"
return "https://gradio-static-files.s3.us-west-2.amazonaws.com/header-image.jpgjpg"

go_btn.click(go, [radio, drop, drop_2, check, name], img, api_name="go")

Expand Down
4 changes: 2 additions & 2 deletions gradio/themes/builder_app.py
View file
Open in desktop
Expand Up @@ -351,7 +351,7 @@ def get_doc_theme_var_groups():
check = gr.Checkbox(label="Go")
with gr.Column(variant="panel", scale=2):
img = gr.Image(
"https://raw.githubusercontent.com/gradio-app/gradio/main/js/_website/src/assets/img/header-image.jpg",
"https://gradio-static-files.s3.us-west-2.amazonaws.com/header-image.jpg",
label="Image",
height=320,
)
Expand All @@ -365,7 +365,7 @@ def get_doc_theme_var_groups():

def go(*args):
time.sleep(3)
return "https://raw.githubusercontent.com/gradio-app/gradio/main/js/_website/src/assets/img/header-image.jpg"
return "https://gradio-static-files.s3.us-west-2.amazonaws.com/header-image.jpg"

go_btn.click(
go,
Expand Down