Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow gr.Interface.from_pipeline() and gr.load() to work within gr.Blocks() #5231

Merged
merged 6 commits into from Aug 16, 2023

Conversation

abidlabs
Copy link
Member

@abidlabs abidlabs commented Aug 15, 2023

We were prematurely rendering components when using Interface.from_pipeline() as well as using gr.load() which meant that you could not use those functions inside of a Blocks(). This fixes those issues and adds a couple of unit tests.

Fixes: #5224

Repros:

import gradio as gr
from transformers import pipeline
classifier = pipeline(task="image-classification")

with gr.Blocks() as demo:
    with gr.Tab("Image Inference"):
        gr.Interface.from_pipeline(classifier)
demo.launch()
import gradio as gr

with gr.Blocks() as demo:
    gr.load("models/google/vit-base-patch16-224")
demo.launch()

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Aug 15, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/ed4be2992c95cb86780f7f83ba18b5fc258a05f5/gradio-3.40.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@ed4be2992c95cb86780f7f83ba18b5fc258a05f5#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Aug 15, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Allow gr.Interface.from_pipeline() and gr.load() to work within gr.Blocks()

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Collaborator

@aliabid94 aliabid94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abidlabs !

gr.Interface.from_pipeline(pipe1)
with gr.Tab("Image Inference"):
gr.Interface.from_pipeline(pipe2)
demo.launch(prevent_thread_lock=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's close the demo when we're done with the test

@abidlabs abidlabs merged commit 87f1c2b into main Aug 16, 2023
19 of 21 checks passed
@abidlabs abidlabs deleted the pipe branch August 16, 2023 05:28
@pngwn pngwn mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface.from_pipeline() does not work with Blocks()
4 participants