fix #5229 #5235
Merged
fix #5229 #5235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
|
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
| @@ -239,6 +239,8 @@ def preprocess( | |||
| return output_file_name | |||
| elif not self.include_audio: | |||
| output_file_name = str(file_name.with_name(f"muted_{file_name.name}")) | |||
| if Path(output_file_name).exists(): | |||
There was a problem hiding this comment.
Can you please add a unit test @breengles ? Otherwise looks good!
There was a problem hiding this comment.
Hi @freddyaboulton! I added a simple test just like the one for the default behavior of gr.Video()
|
Thank you for the contribution @breengles ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add checking if a file already exists when
include_audio=Falsehas been used withgradio.Video(similar to the default behavior).Closes: #5229 (cc: @abidlabs)
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh--- All passed (with 74 warnings, tbh)
You may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.sh--- It affects mainly CHANGELOG.md files in different places, should be ok with the proposed changes to the Video component.