Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes scrollbar from File preview when not needed #5265

Merged
merged 4 commits into from Aug 18, 2023
Merged

Removes scrollbar from File preview when not needed #5265

merged 4 commits into from Aug 18, 2023

Conversation

abidlabs
Copy link
Member

The scrollbar would always show in the gr.File preview. This quick fix removes it when not needed.

Test code:

import gradio as gr

with gr.Blocks() as demo:
    f = gr.File(["cheetah.jpg"]*10)
    
demo.launch()

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Aug 18, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/8e46e5b83f3cb579c702036a468c336e277307b5/gradio-3.40.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@8e46e5b83f3cb579c702036a468c336e277307b5#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Aug 18, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/file patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Removes scrollbar from File preview when not needed

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs abidlabs added the v: patch A change that requires a patch release label Aug 18, 2023
Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @abidlabs!

@abidlabs
Copy link
Member Author

Thanks for the guidance @pngwn!

Copy link
Collaborator

@dawoodkhan82 dawoodkhan82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abidlabs
Copy link
Member Author

Thanks guys! Merging

@abidlabs abidlabs merged commit 0698221 into main Aug 18, 2023
13 checks passed
@abidlabs abidlabs deleted the fpscroll branch August 18, 2023 16:13
@pngwn pngwn mentioned this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants