Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move scripts from old website to CI #5271

Merged
merged 22 commits into from Aug 30, 2023
Merged

Move scripts from old website to CI #5271

merged 22 commits into from Aug 30, 2023

Conversation

aliabd
Copy link
Collaborator

@aliabd aliabd commented Aug 19, 2023

This PR creates a new workflow in the ci that:

  • uploads a wheel of the library to aws on every commit to main
  • uploads all the website demos to spaces on every commit to main (with _main suffix)
  • uploads all the website demos to spaces when a new version is released (no _main suffix)

I tested the workflow on a fork of this repo and finally got it working fine here, and all the spaces were updated correctly.

Also makes some related changes:

  • Adds LoginButton, LogoutButton, and DuplicateButton component demos, and fixes issues with other component demos.
  • Fixes model3d guide and broken demos inside it.
  • Removes an old workflow that used to create the docs when a new gradio version is released on the old website.

Closes: #5204 #5211 #5255

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Aug 19, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details
📓 Notebooks matching!

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/a7fef65ebf9f10813ccd49e50fad5b71a444bfd8/gradio-3.41.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@a7fef65ebf9f10813ccd49e50fad5b71a444bfd8#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Aug 19, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio minor
website minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Move scripts from old website to CI

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

This was linked to issues Aug 19, 2023
@aliabd aliabd self-assigned this Aug 19, 2023
Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reuse the existing upload_demo_to_spaces script and extend the build/deploy PR workflow (adding a push: branches: -main event and changing the demos based on the event)? These changes are mostly duplicates of those files.

@freddyaboulton
Copy link
Collaborator

Can we reuse the existing upload_demo_to_spaces script and extend the build/deploy PR workflow build/deploy PR workflow

Makes sense!

@aliabd
Copy link
Collaborator Author

aliabd commented Aug 29, 2023

@pngwn @freddyaboulton I got this working, removed the new workflow and instead worked it into build-pr/deploy-pr-to-spaces. I did keep the script though as it does a bunch of stuff differently from upload_demo_to_space.

I tested the on a fork here:

(Note there are small differences between the code here and on the fork: basically was easier to test with a different aws bucket I control so tried it there with a different s3 url, but will use @freddyaboulton's bucket here)

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aliabd ! Looks good to me!

@aliabd aliabd merged commit 97c3c7b into main Aug 30, 2023
21 checks passed
@aliabd aliabd deleted the aliabd/website-scripts branch August 30, 2023 18:06
@pngwn pngwn mentioned this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3dModel Tutorial is Broken Add missing component demos to docs Move scripts from old website to CI
4 participants