New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move scripts from old website to CI #5271
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/a7fef65ebf9f10813ccd49e50fad5b71a444bfd8/gradio-3.41.2-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@a7fef65ebf9f10813ccd49e50fad5b71a444bfd8#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we reuse the existing upload_demo_to_spaces
script and extend the build/deploy PR workflow (adding a push: branches: -main
event and changing the demos based on the event)? These changes are mostly duplicates of those files.
Makes sense! |
@pngwn @freddyaboulton I got this working, removed the new workflow and instead worked it into build-pr/deploy-pr-to-spaces. I did keep the script though as it does a bunch of stuff differently from upload_demo_to_space. I tested the on a fork here:
(Note there are small differences between the code here and on the fork: basically was easier to test with a different aws bucket I control so tried it there with a different s3 url, but will use @freddyaboulton's bucket here) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aliabd ! Looks good to me!
This PR creates a new workflow in the ci that:
_main
suffix)_main
suffix)I tested the workflow on a fork of this repo and finally got it working fine here, and all the spaces were updated correctly.
Also makes some related changes:
LoginButton
,LogoutButton
, andDuplicateButton
component demos, and fixes issues with other component demos.Closes: #5204 #5211 #5255