Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow updating the label of gr.UpdateButton #5280

Merged
merged 2 commits into from Aug 21, 2023
Merged

Conversation

abidlabs
Copy link
Member

@abidlabs abidlabs commented Aug 21, 2023

Quick fix needed for idefics demo, cc @yvrjsharma @dawoodkhan82

Test code:

import gradio as gr

def dummy():
  return gr.update(label='🖼️', interactive=True)

def add_text(*args):
    pass

def add_file(*args):
    pass

def bot(*args):
    pass

with gr.Blocks() as demo:
    chatbot = gr.Chatbot([], elem_id="chatbot", height=750)

    with gr.Row():
        with gr.Column(scale=0.85):
            txt = gr.Textbox(
                show_label=False,
                placeholder="Enter text and press enter, or upload an image",
                container=False,
            )
        with gr.Column(scale=0.15, min_width=0):
            btn = gr.UploadButton(label="📁", file_types=["image", "video", "audio"])

    txt_msg = txt.submit(add_text, [chatbot, txt], [chatbot, txt], queue=False).then(
        bot, chatbot, chatbot
    )
    txt_msg.then(lambda: gr.update(interactive=True), None, [txt], queue=False)
    file_msg = btn.upload(add_file, [chatbot, btn], [chatbot], queue=False).then(bot, chatbot, chatbot)
    btn.upload(dummy, [], btn )
    
demo.launch()

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Aug 21, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/ac90bb5318f2394b61be1152495128dd2e899928/gradio-3.40.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@ac90bb5318f2394b61be1152495128dd2e899928#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Allow updating the label of gr.UpdateButton

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@yvrjsharma
Copy link
Collaborator

This works like magic! Crazy speed @abidlabs 🤩🙏

Copy link
Collaborator

@aliabd aliabd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good!

@abidlabs
Copy link
Member Author

Thanks guys

@abidlabs abidlabs merged commit a2f42e2 into main Aug 21, 2023
16 checks passed
@abidlabs abidlabs deleted the update-button-label branch August 21, 2023 18:18
@pngwn pngwn mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants