Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel Dropdown Filter #5360

Merged
merged 5 commits into from Aug 30, 2023
Merged

Conversation

deckar01
Copy link
Contributor

@deckar01 deckar01 commented Aug 28, 2023

When a Dropdown(multiselect=False, allow_custom_value=False) is filtered then blurred, the input value now unconditionally reverts to its selected value and no change or select events occur.

When a dropdown input blurred by its label, the input now stays blurred and its options are hidden.

Closes: #5348

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Aug 28, 2023

🪼 branch checks and previews

Name Status URL
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Aug 28, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/dropdown patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Cancel Dropdown Filter

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@deckar01 deckar01 force-pushed the 5348-dropdown-blur-cancel branch 3 times, most recently from 8c706b0 to 9edaf44 Compare August 29, 2023 01:20
@deckar01 deckar01 mentioned this pull request Aug 29, 2023
1 task
@deckar01 deckar01 marked this pull request as draft August 29, 2023 01:43
@deckar01 deckar01 marked this pull request as ready for review August 29, 2023 15:17
@deckar01
Copy link
Contributor Author

@abidlabs Thank you for your feedback on #5348. This should be ready for review.

@hannahblair
Copy link
Collaborator

hannahblair commented Aug 30, 2023

Thanks for opening this PR @deckar01! I've tested the fix and it works as expected 🙂 I'll go ahead and merge it.

@hannahblair hannahblair merged commit 6466652 into gradio-app:main Aug 30, 2023
9 of 13 checks passed
@pngwn pngwn mentioned this pull request Aug 30, 2023
@deckar01 deckar01 deleted the 5348-dropdown-blur-cancel branch August 30, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown Filter Cancel
4 participants