New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancel Dropdown Filter #5360
Merged
hannahblair
merged 5 commits into
gradio-app:main
from
deckar01:5348-dropdown-blur-cancel
Aug 30, 2023
Merged
Cancel Dropdown Filter #5360
hannahblair
merged 5 commits into
gradio-app:main
from
deckar01:5348-dropdown-blur-cancel
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
|
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
deckar01
force-pushed
the
5348-dropdown-blur-cancel
branch
3 times, most recently
from
August 29, 2023 01:20
8c706b0
to
9edaf44
Compare
deckar01
force-pushed
the
5348-dropdown-blur-cancel
branch
from
August 29, 2023 15:09
774053a
to
8db5602
Compare
deckar01
force-pushed
the
5348-dropdown-blur-cancel
branch
from
August 29, 2023 15:11
8db5602
to
710ad91
Compare
Thanks for opening this PR @deckar01! I've tested the fix and it works as expected 🙂 I'll go ahead and merge it. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
Dropdown(multiselect=False, allow_custom_value=False)
is filtered then blurred, the input value now unconditionally reverts to its selected value and nochange
orselect
events occur.When a dropdown input blurred by its label, the input now stays blurred and its options are hidden.
Closes: #5348