Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renders LaTeX that is added to the page in gr.Markdown, gr.Chatbot, and gr.DataFrame #5393

Merged
merged 5 commits into from Sep 1, 2023

Conversation

abidlabs
Copy link
Member

@abidlabs abidlabs commented Aug 31, 2023

Fixes: #5355. Doesn't break anything as far as I could test.

Try any of the repros in the original issue

Thanks @pngwn for the suggestion

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Aug 31, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/be42a5ded17e725f3227f70fc28877c1dba76780/gradio-3.41.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@be42a5ded17e725f3227f70fc28877c1dba76780#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Aug 31, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/markdown patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Renders LaTeX that is added to the page in gr.Markdown, gr.Chatbot, and gr.DataFrame

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs abidlabs changed the title Quick fix for LaTeX in Markdown Renders LaTeX that is added to the page in gr.Markdown, gr.Chatbot, and gr.DataFrame Aug 31, 2023
Copy link
Collaborator

@aliabid94 aliabid94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm

@abidlabs
Copy link
Member Author

abidlabs commented Sep 1, 2023

Thanks @aliabid94!

@abidlabs abidlabs merged commit e4e7a43 into main Sep 1, 2023
20 of 21 checks passed
@abidlabs abidlabs deleted the streaming-latex branch September 1, 2023 00:28
@pngwn pngwn mentioned this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

problem with streaming a string which has latex code
3 participants