Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds autoscroll param to gr.Textbox() #5488

Merged
merged 5 commits into from Sep 12, 2023
Merged

Adds autoscroll param to gr.Textbox() #5488

merged 5 commits into from Sep 12, 2023

Conversation

dawoodkhan82
Copy link
Collaborator

Description

Add autoscroll param to textbox

Closes: #5487

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Sep 11, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/59c05e6ef5016ac7e9486873b190d24322da9c11/gradio-3.43.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@59c05e6ef5016ac7e9486873b190d24322da9c11#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Sep 11, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/textbox minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Adds autoscroll param to gr.Textbox()

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member

Looks like one of the backed tests needs to fixed to add this parameter to the config but otherwise lgtm!

@dawoodkhan82 dawoodkhan82 merged commit 8909e42 into main Sep 12, 2023
17 of 20 checks passed
@dawoodkhan82 dawoodkhan82 deleted the textbox-autoscroll branch September 12, 2023 22:25
@pngwn pngwn mentioned this pull request Sep 12, 2023
@abidlabs
Copy link
Member

Hmm it looks like some of the backend tests in test/test_blocks.py were failing. I'll fix them in this PR: #5508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add autoscroll parameter to gr.Textbox()
3 participants