Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in example cache loading event #5636

Merged
merged 6 commits into from Sep 20, 2023

Conversation

freddyaboulton
Copy link
Collaborator

Description

Closes: #5634

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Sep 20, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/eddaebe3236dd57cc1874661b927e9beceaf9e16/gradio-3.44.4-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@eddaebe3236dd57cc1874661b927e9beceaf9e16#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Sep 20, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix bug in example cache loading event

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@freddyaboulton freddyaboulton marked this pull request as ready for review September 20, 2023 17:12
# Let the server shut down
time.sleep(1)

with connect(demo, server_port=7859) as client:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, you launch on the same port to ensure that the server truly has shutdown? I don't think you need to do this.

Even if demo.launch() were to launch a FastAPI app on a new port, it would still read from the same cache since the ids of the components hasn't changed.

So you can remove the hardcoding of the server ports (which will be better in case this port is occupied)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The time.sleep is to ensure shutdown. Hardcoding the same port is for paranoia 😂 Let me fix.

@abidlabs
Copy link
Member

Bad whitespace! Nice fix @freddyaboulton

This actually also fixes: #5521

Left a nit about the tests. Otherwise lgtm!

@freddyaboulton freddyaboulton merged commit fb5964f into main Sep 20, 2023
16 checks passed
@freddyaboulton freddyaboulton deleted the 5634-cached-example-event-fix branch September 20, 2023 19:03
@pngwn pngwn mentioned this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot display outputs when reusing cached examples
3 participants