Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep Markdown rendered lists within dataframe cells #5878

Merged
merged 11 commits into from Oct 12, 2023
Merged

Keep Markdown rendered lists within dataframe cells #5878

merged 11 commits into from Oct 12, 2023

Conversation

abidlabs
Copy link
Member

@abidlabs abidlabs commented Oct 12, 2023

Fixes: #5802 for <ul> and <ol>:

Before:

image

After:

image

Note that chatbot markdown actually looks better without this change, so I excluded chatbot markdown from the css selector.

@sweep-ai
Copy link
Contributor

sweep-ai bot commented Oct 12, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Oct 12, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/0f2baea8c7d02f0772479d30d568d574faf4b9e3/gradio-3.47.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@0f2baea8c7d02f0772479d30d568d574faf4b9e3#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Oct 12, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/markdown patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Keep Markdown rendered lists within dataframe cells

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs abidlabs changed the title Keep Markdown rendered lists within dataframe cells Keep Markdown rendered lists within dataframe cells, and allows links to wrap Oct 12, 2023
@abidlabs abidlabs changed the title Keep Markdown rendered lists within dataframe cells, and allows links to wrap Keep Markdown rendered lists within dataframe cells Oct 12, 2023
Copy link
Collaborator

@hysts hysts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@abidlabs
Copy link
Member Author

Thanks @hysts! Looking into your other issues related to the Dataframe as well

@abidlabs abidlabs merged commit fbce277 into main Oct 12, 2023
13 checks passed
@abidlabs abidlabs deleted the df-bullets branch October 12, 2023 03:52
This was referenced Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown list is not rendered properly in gr.Dataframe
3 participants