Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed visibility issue for all notebooks on GitHub #5917

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Fixed visibility issue for all notebooks on GitHub #5917

merged 3 commits into from
Oct 16, 2023

Conversation

Archit-Kohli
Copy link
Contributor

Description

This pull request just changes the inner JSON format of all run.ipynb files in gradio/demo/ and makes the cell ids strings, thus making it a valid notebook which can now be seen in GitHub itself

Closes: #5916

Please merge my pull request and if possible add the hacktoberfest label

@sweep-ai
Copy link
Contributor

sweep-ai bot commented Oct 15, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@pngwn
Copy link
Member

pngwn commented Oct 15, 2023

@Archit-Kohli Thanks for taking care of this!

We also need to update the python file that generates the notebooks to make sure we don't reintroduce this problem. It is in demo/generate_notebooks.py. Could you update that as well?

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Oct 15, 2023

🪼 branch checks and previews

Name Status URL
🦄 Changes detected! Details
📓 Notebooks not matching! Details

The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes:

pip install nbformat && cd demo && python generate_notebooks.py

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Oct 15, 2023

🦄 no changes detected

This Pull Request does not include changes to any packages.

__No changes detected. __

  • Maintainers can select this checkbox to manually select packages to update.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can create the changelog file directly.

fixed a small bug that prevented visibility of notebooks in GitHub
@Archit-Kohli
Copy link
Contributor Author

@Archit-Kohli Thanks for taking care of this!

We also need to update the python file that generates the notebooks to make sure we don't reintroduce this problem. It is in demo/generate_notebooks.py. Could you update that as well?

Just did that 👍

@abidlabs
Copy link
Member

Thank you @Archit-Kohli this is very nice!

@abidlabs abidlabs merged commit 921716f into gradio-app:main Oct 16, 2023
10 of 15 checks passed
@hannahblair
Copy link
Collaborator

Hey @Archit-Kohli!

We wanted to reach out to thank you for your contributions to gradio. We're giving away Hugging Face merch to contributors during Hacktoberfest, and we'd like to send you something! Would you be able to send an email to team@gradio.app so we can get in touch?

@Archit-Kohli
Copy link
Contributor Author

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid Notebook error in most of the run.ipynb files in gradio/demo/<any_folder> in GitHub
5 participants