-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed visibility issue for all notebooks on GitHub #5917
Conversation
deleted script used to fix notebooks
Apply Sweep Rules to your PR?
|
@Archit-Kohli Thanks for taking care of this! We also need to update the python file that generates the notebooks to make sure we don't reintroduce this problem. It is in |
🪼 branch checks and previews
The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes: pip install nbformat && cd demo && python generate_notebooks.py |
🦄 no changes detectedThis Pull Request does not include changes to any packages.__No changes detected. __
|
fixed a small bug that prevented visibility of notebooks in GitHub
Just did that 👍 |
Thank you @Archit-Kohli this is very nice! |
Hey @Archit-Kohli! We wanted to reach out to thank you for your contributions to gradio. We're giving away Hugging Face merch to contributors during Hacktoberfest, and we'd like to send you something! Would you be able to send an email to team@gradio.app so we can get in touch? |
Sure |
Description
This pull request just changes the inner JSON format of all run.ipynb files in gradio/demo/ and makes the cell ids strings, thus making it a valid notebook which can now be seen in GitHub itself
Closes: #5916
Please merge my pull request and if possible add the hacktoberfest label