Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap websockets for SSE #6069
Swap websockets for SSE #6069
Changes from 17 commits
e7cfeb6
6f54f20
a828a6c
36aaaf5
a21fbf1
7b88e8d
fbe580f
a4f7759
5a42da7
608842e
6b446fd
cc35772
ef6a299
7315f48
e9b416e
56c6a31
3ad6fe8
1b0005f
efb6986
9d4b19a
7052464
d4b6023
09dd08e
efe2990
3760d5b
3168903
a43f49f
1a670da
d94b3db
266aec2
79987a3
103d78a
f9cfd29
d32e68e
d712f5a
abeb701
5bfbc27
78a700a
9be2c16
dc95b3d
e8f4a2d
d25616e
d1c4bc6
6246d5e
ea2aa97
d35a890
165466a
ec2cd06
ca5fac4
60572e0
22b7d26
732e1b7
ef7bcd7
373ba21
3bc906e
44eda09
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: let's modify and
use_ws
to check if the protocol is "ws" or "sse" since we're using it in different placesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry don't understand what you're suggesting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, instead of
self.endpoints[inferred_fn_index].protocol in ("ws", "sse")
in multiple places, we doself.endpoints[inferred_fn_index].use_http
or something like that.