Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add likeable to config for Chatbot #6231

Merged
merged 5 commits into from Nov 1, 2023

Conversation

freddyaboulton
Copy link
Collaborator

@freddyaboulton freddyaboulton commented Nov 1, 2023

Description

Repro in issue.

We added some under-the-hood logic to Blocks to set _selectable in the config without it being present in the init signature. I don't like treating some props as privileged though. Doesn't scale for custom component authors who want to set event-based props in their custom component. So I'm adding likeable to the config.

Closes: #6230

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Nov 1, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/b3d59fb600dc752e4aa6360c6c32d871581a895e/gradio-4.0.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@b3d59fb600dc752e4aa6360c6c32d871581a895e#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Nov 1, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Add likeable to config for Chatbot

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@freddyaboulton freddyaboulton marked this pull request as ready for review November 1, 2023 17:54
@@ -1895,6 +1895,16 @@ def test_component_functions(self):
"_selectable": False,
}

def test_chatbot_selectable_in_config(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def test_chatbot_selectable_in_config(self):
def test_chatbot_likeable_in_config(self):

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can also test to ensure that likable is not present if no .like event has been set

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea good idea!

@abidlabs
Copy link
Member

abidlabs commented Nov 1, 2023

I don't like treating some props as privileged though. Doesn't scale for custom component authors who want to set event-based props in their custom component. So I'm adding likeable to the config.

Makes sense. Let's also do the same for _selectable then for consistency across components. We'll add it back as a param to all of the components and do it in a backwards compatible way to support gr.load() components with the _selectable key. I can take care of this in a separate PR.

@abidlabs
Copy link
Member

abidlabs commented Nov 1, 2023

Oh tested, works well. LGTM!

@freddyaboulton
Copy link
Collaborator Author

Thanks @abidlabs !

@freddyaboulton freddyaboulton merged commit 3e31c17 into main Nov 1, 2023
16 checks passed
@freddyaboulton freddyaboulton deleted the fix-chatbot-like-dislike-button branch November 1, 2023 20:32
@pngwn pngwn mentioned this pull request Nov 1, 2023
pngwn pushed a commit that referenced this pull request Nov 3, 2023
* Add likeable to config

* add changeset

* Add test

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chatbot like/dislike not displaying even when like event is set
3 participants