New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add likeable to config for Chatbot #6231
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/b3d59fb600dc752e4aa6360c6c32d871581a895e/gradio-4.0.2-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@b3d59fb600dc752e4aa6360c6c32d871581a895e#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
@@ -1895,6 +1895,16 @@ def test_component_functions(self): | |||
"_selectable": False, | |||
} | |||
|
|||
def test_chatbot_selectable_in_config(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def test_chatbot_selectable_in_config(self): | |
def test_chatbot_likeable_in_config(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can also test to ensure that likable is not present if no .like
event has been set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea good idea!
Makes sense. Let's also do the same for |
Oh tested, works well. LGTM! |
Thanks @abidlabs ! |
* Add likeable to config * add changeset * Add test --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
Description
Repro in issue.
We added some under-the-hood logic to Blocks to set
_selectable
in the config without it being present in the init signature. I don't like treating some props as privileged though. Doesn't scale for custom component authors who want to set event-based props in their custom component. So I'm adding likeable to the config.Closes: #6230
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh