Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model3D panning, improved UX #6240

Merged
merged 2 commits into from Nov 1, 2023
Merged

Model3D panning, improved UX #6240

merged 2 commits into from Nov 1, 2023

Conversation

dylanebert
Copy link
Contributor

Improvements to the Model3D component

  • Enabled panning
  • Adapt pan and zoom speed to scene radius, creating a consistent experience across various model sizes
  • Set lower radius limit to prevent zoom inversion (zooming in below 0)

Closes: #6119

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Nov 1, 2023

🪼 branch checks and previews

Name Status URL
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

@gradio-pr-bot
Copy link
Contributor

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/model3d minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Model3D panning, improved UX

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member

abidlabs commented Nov 1, 2023

LGTM tested on mobile as well. This:

Set lower radius limit to prevent zoom inversion (zooming in below 0)

is really nice, thanks @dylanebert!

@abidlabs abidlabs merged commit dd901c1 into gradio-app:main Nov 1, 2023
12 of 16 checks passed
@pngwn pngwn mentioned this pull request Nov 1, 2023
pngwn pushed a commit that referenced this pull request Nov 3, 2023
* Model3D panning, improved UX

* add changeset

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model3D panning and UX improvements
3 participants