Ensure Model 3D updates when attributes change #6255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/7fc510b867f605acfb06cd72ec293afd4dceefc4/gradio-4.0.2-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@7fc510b867f605acfb06cd72ec293afd4dceefc4#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
…to fix-model3d-updates
|
actually I might be able to change this such that it doesn’t reload the whole scene |
|
Tested and works great! Thanks @hannahblair for the quick fix Edit: sorry just saw your comment. Happy to review again if needed! |
abidlabs
approved these changes
Nov 2, 2023
pngwn
previously approved these changes
Nov 3, 2023
|
Lmk when you are ready for a review again sorry, missed that final comment. I think you can just make the modifications to the camera directly with out creating a new one at the top of the function. |
|
@pngwn turns out directly changing the camera also re-renders the scene, so I'll merge this in as is |
Merged
pngwn
pushed a commit
that referenced
this pull request
Nov 3, 2023
* trigger scene update when params change * add changeset * formatting --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Model3D updated when
valuechanges, but we weren't triggering a scene reset when the camera position, zoom, or pan changed.Closes: #6209
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.sh