Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle selected_index prop change for gallery #6277

Merged
merged 2 commits into from Nov 3, 2023
Merged

handle selected_index prop change for gallery #6277

merged 2 commits into from Nov 3, 2023

Conversation

pngwn
Copy link
Member

@pngwn pngwn commented Nov 3, 2023

Description

Closes #6276.

This is a tricky one. This is a quick fix for gr.Gallery but we may have a similar issues for other components. This is an architectural issue really. We don't keep track of every prop change at the top level.

I'll look into a more comprehensive fix shortly.

Edit: opened an issue for the root problem (#6278)

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Nov 3, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details
📓 Notebooks matching!

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/1d7bf85013b677592aac12f9209fd85e7ba7f7bd/gradio-4.0.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@1d7bf85013b677592aac12f9209fd85e7ba7f7bd#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Nov 3, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/gallery patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

handle selected_index prop change for gallery

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the fix @pngwn thanks! End to end test? 😄

@pngwn
Copy link
Member Author

pngwn commented Nov 3, 2023

Hard to test because the fix only changes styling. I'll figure out some tests when I look at the real fix.

@pngwn pngwn merged commit 5fe0913 into main Nov 3, 2023
16 checks passed
@pngwn pngwn deleted the 6276-gallery branch November 3, 2023 16:08
@pngwn pngwn mentioned this pull request Nov 3, 2023
@zixaphir
Copy link

Hello! I am a bit confused by this solution. Is this creating a new Gradio.Gallery object and feeding its selected_index property to an existing Gradio.Gallery object? Would it be possible to pass selected_index property to a Gradio.Gallery.update call instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gr.Gallery selected_index doesn't update as expected
4 participants