New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure source selection does not get hidden in overflow #6279
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/c66ea0328e088a5387350d556912928edafd0049/gradio-4.1.1-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@c66ea0328e088a5387350d556912928edafd0049#subdirectory=client/python" |
{waveform_settings} | ||
{handle_reset_value} | ||
/> | ||
<div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know why the overflow started happening in the first place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should've marked this as draft because this shouldn't be the fix really. Here's the space with the first implementation of it working fine and it didn't need this wrapper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meant to ask this here:
Does the image already do this? Is this not something that Block in atoms can solve?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried a few things to address it with Block
but ultimately the issue is with the Upload
button pushing out the source selection component in certain heights
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
…o fix-source-styling
…o fix-source-styling
…o fix-source-styling
…o fix-source-styling
…o fix-source-styling
@@ -0,0 +1,74 @@ | |||
<script lang="ts"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes are just moving the source selection over to a reusable component
@@ -94,6 +95,7 @@ | |||
class:center | |||
class:boundedheight | |||
class:flex | |||
style:height={include_sources ? "calc(100% - 40px" : "100%"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the actual fix for the issue
@@ -227,6 +228,7 @@ | |||
bind:dragging | |||
on:error={({ detail }) => dispatch("error", detail)} | |||
{root} | |||
include_sources={sources.length > 1} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if there's a better name for this param
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for taking care of this @hannahblair!
Description
Fixes the overflow of the source selection element in video and audio.
Closes: #6258
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh