ensure gr.Dataframe updates as expected
#6290
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/89510ec549e9320cef9043d7c18360660cab29dd/gradio-4.1.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@89510ec549e9320cef9043d7c18360660cab29dd#subdirectory=client/python" |
|
unit test would have caught this, i don't have time to write one now but i'll add it to the list. |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
| @@ -99,6 +99,7 @@ | |||
| {col_count} | |||
| {value} | |||
| {headers} | |||
| on:change={(e) => (value = e.detail)} | |||
There was a problem hiding this comment.
very upsetting that it took me so long to find it tbh. i guess you often miss the obvious stuff.
There was a problem hiding this comment.
I spent a couple hours trying different things so I feel like you got it pretty fast 😄
pngwn
changed the title
gr.Dataframe updates as expected
|
Wait hmm I'm not sure if this fixed it for me |
|
hmmmm |
|
The issue I'm seeing is that if I change the value of a cell and blur, it reverts to the original value |
|
well |
|
i wonder if i broke that with my fix |
|
Well in one sense the original bug is now fixed since you can't change the value of the dataframe at all 😆 |
|
But yeah I think the blur changes are breaking something |
|
yeh, i broke it sec. |
|
okay that should do it, there is a small bug around clicking but i think we should get this out now and fix the click bug later. It isn't too awful. |
|
Filed an issue: #6291 |
|
LGTM @pngwn! |
Description
Closes #6252.
Silly omissions when refactoring. Also fixed a weird bug that didn't really make sense to me but seems to work ok now.
Closes: #(issue)
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.sh