Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix to be able to load themes from Hub #6311

Merged
merged 7 commits into from Nov 6, 2023
Merged

Temporary fix to be able to load themes from Hub #6311

merged 7 commits into from Nov 6, 2023

Conversation

abidlabs
Copy link
Member

@abidlabs abidlabs commented Nov 6, 2023

Commented out a check to make sure that the loaded theme has the correct tags, as it seems that the huggingface_hub library is not parsing tags from Spaces

Closes: #6298

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Nov 6, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/9b304588dbbd277fff918acdd2a60cbe9c25b7de/gradio-4.1.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@9b304588dbbd277fff918acdd2a60cbe9c25b7de#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Nov 6, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Temporary fix to be able to load themes from Hub

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

cc @Wauplin . Looks like something is up with getting tags from space readmes?

@abidlabs
Copy link
Member Author

abidlabs commented Nov 6, 2023

Thanks @freddyaboulton for the review. Created an issue here @Wauplin: huggingface/huggingface_hub#1806

@abidlabs abidlabs merged commit 176c4d1 into main Nov 6, 2023
22 of 23 checks passed
@abidlabs abidlabs deleted the themes branch November 6, 2023 23:40
@pngwn pngwn mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gr.Theme.from_hub error
3 participants