Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve default source behaviour in Audio #6314

Merged
merged 6 commits into from Nov 7, 2023

Conversation

hannahblair
Copy link
Collaborator

@hannahblair hannahblair commented Nov 7, 2023

Description

  • Notes that the default input source is the first element in the sources list
  • Highlights the current active state in the source selection
  • Sets upload as the default source if sources is None

Closes: #6284

Screenshot 2023-11-07 at 13 51 18

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Nov 7, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/8c2f0ad452028ba5828615c42718b5dd8d603f31/gradio-4.1.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@8c2f0ad452028ba5828615c42718b5dd8d603f31#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Nov 7, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/atoms patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Improve default source behaviour in Audio

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@hannahblair hannahblair changed the title Improve default audio behaviour Improve default source behaviour in Audio Nov 7, 2023
Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! lgtm

Is the same behavior true for Video and Image as well? Would be good to note in their docstrings as well. (can be a separate pr)

@hannahblair
Copy link
Collaborator Author

hannahblair commented Nov 7, 2023

@abidlabs yep I agree! will do.

@hannahblair hannahblair merged commit fad92c2 into main Nov 7, 2023
15 of 16 checks passed
@hannahblair hannahblair deleted the amend-default-audio-state branch November 7, 2023 13:47
@pngwn pngwn mentioned this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants