Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain text selection in Chatbot button elements #6316

Merged
merged 4 commits into from Nov 7, 2023

Conversation

hannahblair
Copy link
Collaborator

Description

Adds user-select: text to chatbot message buttons to ensure users can select the text.

Closes: #6256

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@hannahblair hannahblair changed the title Maintain text selection in Chatbot buttons Maintain text selection in Chatbot button elements Nov 7, 2023
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Nov 7, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/19af9e3119b418dfabf35817463c6397dd734cef/gradio-4.1.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@19af9e3119b418dfabf35817463c6397dd734cef#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Nov 7, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/chatbot patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Maintain text selection in Chatbot button elements

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member

abidlabs commented Nov 7, 2023

Cool! Will take a look

@hannahblair do you think a similar fix would resolve #6086?

@abidlabs
Copy link
Member

abidlabs commented Nov 7, 2023

Fixes it for me, nice!

@abidlabs abidlabs merged commit 4b1011b into main Nov 7, 2023
20 checks passed
@abidlabs abidlabs deleted the message-selection-chatbot branch November 7, 2023 19:26
@pngwn pngwn mentioned this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chatbox changed from div to button, breaking text selection on firefox and messing up in other browsers
3 participants