Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AsyncGenerator to the check-list of dependencies.types.generator #6333

Merged
merged 3 commits into from Nov 8, 2023

Conversation

whitphx
Copy link
Member

@whitphx whitphx commented Nov 8, 2023

Description

This is kind of a question, rather than a change request/proposal.

I wonder inspect.isasyncgenfunction() should be added here because it is usually used along with inspect.isgeneratorfunction in other places to check the function is generator-like,
such as:

gradio/gradio/interface.py

Lines 457 to 459 in f1409f9

if inspect.isgeneratorfunction(
self.fn
) or inspect.isasyncgenfunction(self.fn):

gradio/gradio/interface.py

Lines 464 to 466 in f1409f9

if (
inspect.isgeneratorfunction(self.fn)
or inspect.isasyncgenfunction(self.fn)

If not, plz close the PR.

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Nov 8, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/ae78903fe7f650d7710045ecb9e31bae520a5252/gradio-4.1.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@ae78903fe7f650d7710045ecb9e31bae520a5252#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Nov 8, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Add AsyncGenerator to the check-list of dependencies.types.generator

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member

abidlabs commented Nov 8, 2023

Yes it should! Thanks for catching @whitphx, lgtm

@abidlabs abidlabs added the v: patch A change that requires a patch release label Nov 8, 2023
@whitphx whitphx marked this pull request as ready for review November 8, 2023 14:45
@whitphx whitphx merged commit 42f76ae into main Nov 8, 2023
15 of 16 checks passed
@whitphx whitphx deleted the dependencies-generator-flag-async branch November 8, 2023 14:46
@pngwn pngwn mentioned this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants