Fix image upload #6363
Merged
Fix image upload #6363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/ad0cc31abe0a58e6ce15a3fbfe40294ffc5c0bef/gradio-4.1.2-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@ad0cc31abe0a58e6ce15a3fbfe40294ffc5c0bef#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
freddyaboulton
commented
Nov 9, 2023
| @@ -122,7 +122,7 @@ | |||
|
|
|||
| <ImageUploader | |||
| bind:active_tool | |||
| bind:value={_value} | |||
| bind:value | |||
There was a problem hiding this comment.
What was happening is that we were binding to _value so the value prop (which is what gets passed to events) was never updated during the upload.
I think this is the right thing to do. By binding to value, _value will automatically be updated. Also the ImageUploaded calls normalise_file so value will have the right url
There was a problem hiding this comment.
freddyaboulton
requested review from
aliabid94,
aliabd,
dawoodkhan82,
pngwn and
hannahblair
|
LGTM thanks @freddyaboulton for the nice fix! |
abidlabs
approved these changes
Nov 10, 2023
|
Thanks for the reivew @abidlabs !! |
Merged
freddyaboulton
added a commit
that referenced
this pull request
Nov 10, 2023
* Fix upload * add changeset * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
freddyaboulton
added a commit
that referenced
this pull request
Nov 13, 2023
* WIP guide * Add remaining * build command * remove pin from guides * add changeset * Tweaks * add changeset * format * Update guides/05_custom-components/07_pdf-component-example.md Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * Redesign file upload (#6356) * Textbox and Code Component Blur/Focus Fixes (#6323) * focus and blur events * format * add changeset * fixes * fixes * format --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> * Fix image upload (#6363) * Fix upload * add changeset * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> * Add demo to the beginning * Add example and note about the name * Incorporate feedback --------- Co-authored-by: aliabd <ali.si3luwa@gmail.com> Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co> Co-authored-by: Hannah <hannahblair@users.noreply.github.com> Co-authored-by: Dawood Khan <dawoodkhan82@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix image upload
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.sh