Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Model3D download button and other issues #6414

Merged
merged 7 commits into from Nov 14, 2023
Merged

Conversation

freddyaboulton
Copy link
Collaborator

Description

Closes: #6325

Also fixes some more issues with Model3D

  • The upload event was not triggering
  • The clear event was not triggering a change event

Added an e2e test for this too!

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Nov 13, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details
📓 Notebooks matching!

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/957bdb69c487b06c3007feeba7753f3b68c0f478/gradio-4.2.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@957bdb69c487b06c3007feeba7753f3b68c0f478#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Nov 13, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/model3d patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix Model3D download button and other issues

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@freddyaboulton freddyaboulton changed the title Add code FIx Model3D download button and other issuei Nov 13, 2023
@freddyaboulton freddyaboulton changed the title FIx Model3D download button and other issuei Fix Model3D download button and other issuei Nov 13, 2023
@freddyaboulton freddyaboulton changed the title Fix Model3D download button and other issuei Fix Model3D download button and other issues Nov 13, 2023
@abidlabs
Copy link
Member

LGTM! Thanks for adding the e2e test @freddyaboulton

@abidlabs
Copy link
Member

Merging so that we can get it out for the release!

@abidlabs abidlabs merged commit da1e318 into main Nov 14, 2023
24 checks passed
@abidlabs abidlabs deleted the 6325-model3d-download branch November 14, 2023 01:13
@pngwn pngwn mentioned this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model3D download no longer working
3 participants