Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev mode #6467

Merged
merged 3 commits into from Nov 17, 2023
Merged

Fix dev mode #6467

merged 3 commits into from Nov 17, 2023

Conversation

freddyaboulton
Copy link
Collaborator

@freddyaboulton freddyaboulton commented Nov 17, 2023

Description

I broke dev mode lol. Let's do a new release when this is merged.

About to take off, it's working for me locally so opening for review!

You can test by creating a new component and running gradio cc dev

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Nov 17, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/3b0ccaa5d4ad3d117853fa3b2c5acd68fc7bae95/gradio-4.4.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@3b0ccaa5d4ad3d117853fa3b2c5acd68fc7bae95#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Nov 17, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/preview patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix dev mode

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@freddyaboulton freddyaboulton marked this pull request as ready for review November 17, 2023 12:31
@freddyaboulton freddyaboulton added the v: patch A change that requires a patch release label Nov 17, 2023
Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, nice catch. Thanks @freddyaboulton!

@freddyaboulton
Copy link
Collaborator Author

Thanks @pngwn !!

@freddyaboulton freddyaboulton merged commit 739e3a5 into main Nov 17, 2023
13 checks passed
@freddyaboulton freddyaboulton deleted the fix-dev-mode branch November 17, 2023 15:14
@pngwn pngwn mentioned this pull request Nov 17, 2023
freddyaboulton added a commit that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants