Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure image editor crop and draw cursor works as expected when the scroll position changes #6502

Merged
merged 2 commits into from Nov 20, 2023

Conversation

pngwn
Copy link
Member

@pngwn pngwn commented Nov 20, 2023

Description

I am not here. I did not make this PR

There was a bug (pretty bad one imo), where the crop and draw/erase cursor would get funky if the user scrolled the page after uploading an image. This is because they rely on DOM measurements but those measurements are not updated on scroll. This PR fixes that.

Also corrected the typos in the docstrings.

Closes: #(issue)

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@pngwn pngwn added v: patch A change that requires a patch release t: fix A change that implements a fix labels Nov 20, 2023
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Nov 20, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/ce5c4d2bd55c670cfc4d55a9b8739e4ba643c374/gradio-4.4.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@ce5c4d2bd55c670cfc4d55a9b8739e4ba643c374#subdirectory=client/python"

@pngwn
Copy link
Member Author

pngwn commented Nov 20, 2023

cc @hysts

@gradio-pr-bot
Copy link
Contributor

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/imageeditor patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Ensure image editor crop and draw cursor works as expected when the scroll position changes

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@pngwn pngwn merged commit 070f71c into main Nov 20, 2023
15 checks passed
@pngwn pngwn deleted the im-ed-scroll-pos branch November 20, 2023 15:13
@pngwn pngwn mentioned this pull request Nov 20, 2023
freddyaboulton pushed a commit that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: fix A change that implements a fix v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants