Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix related to stories #6658

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Hotfix related to stories #6658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caa651e
format
abidlabs Dec 4, 2023
c346099
Merge branch 'main' into story-fix
abidlabs Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/dropdown/Multiselect.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
</Template>

<Story
name="Multiselect"
name="Multiselect Interactive"
args={{
value: ["swim", "run"],
choices: [
Expand Down
2 changes: 1 addition & 1 deletion js/highlightedtext/HighlightedText.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
/>
</Template>

<Story name="Highlighted Text" />
<Story name="Highlighted Text Default" />
<Story name="Highlighted Text with legend" args={{ show_legend: true }} />
<Story name="Highlighted Text with label" args={{ label: "animals" }} />
<Story
Expand Down
2 changes: 1 addition & 1 deletion js/row/Row.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@
</Row>
</Template>

<Story name="Row" />
<Story name="Row Layout" />
16 changes: 0 additions & 16 deletions js/video/Video.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,23 +76,7 @@
}}
play={async ({ canvasElement }) => {
const canvas = within(canvasElement);

const trimButton = canvas.getByLabelText("Trim video to selection");

userEvent.click(trimButton);

await new Promise((r) => setTimeout(r, 4000));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This timeout was not sufficiently long enough for the element to appear, causing the storybook CI action to crash. @hannahblair I think we'll need to use a different approach.


const rightHandle = canvas.getByLabelText(
"end drag handle for trimming video"
);

userEvent.click(rightHandle);

for (let i = 0; i < 4; i++) {
await userEvent.keyboard("[ArrowRight]");
}

userEvent.click(canvas.getByText("Trim"));
}}
/>
140 changes: 25 additions & 115 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.