Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit video media within Video component #6698

Merged
merged 7 commits into from Dec 7, 2023
Merged

Conversation

hannahblair
Copy link
Collaborator

@hannahblair hannahblair commented Dec 7, 2023

Description

A div wrapper was added around the video component in commit b671153 which used the mirror attribute. This changed the fit of the video within the component. We just needed to add the position, width and height attributes to that wrapper fix this.

Closes: #6539

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Dec 7, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/41676d569b6dea4fc36232652cc99b3f728a1aac/gradio-4.8.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@41676d569b6dea4fc36232652cc99b3f728a1aac#subdirectory=client/python"

@hannahblair hannahblair changed the title Fit video media in Video Fit video media within Video component Dec 7, 2023
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Dec 7, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/video patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fit video media within Video component

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks gioiod! Thanks for taking care of this @hannahblair!

@hannahblair hannahblair merged commit 798eca5 into main Dec 7, 2023
22 checks passed
@hannahblair hannahblair deleted the fix-video-position branch December 7, 2023 17:19
@pngwn pngwn mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why have an issue with videos not being centered automatically after updating to version 3.48.0 or later?
3 participants