Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure LoginButton value text is displayed #6808

Merged
merged 8 commits into from Dec 15, 2023
Merged

Conversation

hannahblair
Copy link
Collaborator

@hannahblair hannahblair commented Dec 15, 2023

Description

When initialising a LoginButton, we were hardcoding the button with the value "Sign in with Hugging Face". This changes that, so that self.value is used instead, which defaults to Sign in with Hugging Face if not provided.

Closes: #6772

Test:

import gradio as gr 

with gr.Blocks() as demo:
    gr.LoginButton(value="boop")

demo.launch()

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Dec 15, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook failed! Details
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/702e6b3525501907897e6b3f1a78e713617f20c5/gradio-4.9.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@702e6b3525501907897e6b3f1a78e713617f20c5#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Dec 15, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Ensure LoginButton value text is displayed

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member

This looks good @hannahblair -- could we also add a signed_in_value parameter as mentioned in: #6772 (comment)

@hannahblair
Copy link
Collaborator Author

hannahblair commented Dec 15, 2023

@abidlabs Oh of course! That's done.

@abidlabs
Copy link
Member

LGTM thanks @hannahblair for taking care of this!

@hannahblair hannahblair merged commit 6b130e2 into main Dec 15, 2023
12 of 15 checks passed
@hannahblair hannahblair deleted the loginbutton-update-text branch December 15, 2023 19:48
@pngwn pngwn mentioned this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize gr.LoginButton() text
3 participants