New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E test that Queue Full does not break the client. Also that backend exceptions don't break the client or queue. #6812
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/1b221afd8b85f84d725b05e94edddd70c894a25c/gradio-4.10.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@1b221afd8b85f84d725b05e94edddd70c894a25c#subdirectory=client/python" |
🦄 no changes detectedThis Pull Request does not include changes to any packages.__No changes detected. __
|
@@ -0,0 +1,30 @@ | |||
import { test, expect } from "@gradio/tootils"; | |||
import { launch_app_background, kill_process } from "./utils"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imports not used?
await expect | ||
.poll(async () => page.getByLabel("First Result").inputValue()) | ||
.toBeTruthy(); | ||
await expect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo. Will fix in another PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @aliabid94 ! |
Description
Closes: #6713
Follow up from #6798
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh