Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust rounding logic when precision is None in gr.Number() #6829

Merged
merged 4 commits into from Dec 18, 2023

Conversation

hannahblair
Copy link
Collaborator

@hannahblair hannahblair commented Dec 18, 2023

Description

Adjusts the _round_to_precision func logic such that if precision is None, we return num without casting the value to float.

Closes: #6786

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@hannahblair hannahblair changed the title Adjust rounding logic when precision is None in gr.Number Adjust rounding logic when precision is None in gr.Number() Dec 18, 2023
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Dec 18, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/6e0592325721d4b295161461f00fc5ad8c39b96d/gradio-4.10.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@6e0592325721d4b295161461f00fc5ad8c39b96d#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Dec 18, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Adjust rounding logic when precision is None in gr.Number()

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @hannahblair Thanks!

@dawoodkhan82 dawoodkhan82 self-requested a review December 18, 2023 22:25
Copy link
Collaborator

@dawoodkhan82 dawoodkhan82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks for adding the tests

@hannahblair hannahblair merged commit 50496f9 into main Dec 18, 2023
17 checks passed
@hannahblair hannahblair deleted the fix-number-precision-logic branch December 18, 2023 23:42
@pngwn pngwn mentioned this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gr.Number should not cast value as float if precision is None, to be consistent with gr.Slider
4 participants