Fix md highlight #6842
Merged
Fix md highlight #6842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pngwn
commented
Dec 19, 2023
| @@ -128,28 +127,26 @@ export function create_marked({ | |||
| ); | |||
|
|
|||
| if (header_links) { | |||
| if (header_links) { | |||
There was a problem hiding this comment.
dno why we had this double if
pngwn
commented
Dec 19, 2023
| @@ -110,6 +107,8 @@ export function create_marked({ | |||
| header_links: boolean; | |||
| line_breaks: boolean; | |||
| }): typeof marked { | |||
| const marked = new Marked(); | |||
There was a problem hiding this comment.
Fresh instance per 'create_marked`.
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/cd6393bc3fbf084578de5a5c3f04a54af087a610/gradio-4.10.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@cd6393bc3fbf084578de5a5c3f04a54af087a610#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
pngwn
commented
Dec 19, 2023
There was a problem hiding this comment.
We were basically adding all plugins to the same renderer for every instance of the component. So 2 instances would be 2 highlighters. And i think that basically meant that the highlighted code was being passed through the highlighter again (but at that point it was html code).
Merged
whitphx
pushed a commit
that referenced
this pull request
Dec 20, 2023
* ensure gr.Markdown instances have their own instance of the markdown renderer * fix demo * add changeset * skopip test --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
some weird issues as we were reusing the same marked instance across multiple instances of
gr.Markdown. The issues only seems to present when more than on markdown component is used.https://marked.js.org/using_advanced#instance
The quickstart for marked is idiotic in the extreme but this should fix it.
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.sh