Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webcam when streaming=True #6865

Merged
merged 3 commits into from Dec 21, 2023
Merged

Fix webcam when streaming=True #6865

merged 3 commits into from Dec 21, 2023

Conversation

hannahblair
Copy link
Collaborator

@hannahblair hannahblair commented Dec 21, 2023

Description

#6766 broke the Webcam when streaming is true due to a !value check when rendering <Webcam />. This PR fixes that logic and adds a story test.

Closes: #6858

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Dec 21, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/994c01558bb2c6c407c8c824c7493306e77b2618/gradio-4.11.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@994c01558bb2c6c407c8c824c7493306e77b2618#subdirectory=client/python"

@hannahblair hannahblair changed the title Fix webcam streaming Fix webcam when streaming=True Dec 21, 2023
@gradio-pr-bot
Copy link
Contributor

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/image patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix webcam when streaming=True

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs abidlabs self-requested a review December 21, 2023 17:57
@abidlabs
Copy link
Member

LGTM, thanks for adding the story @hannahblair!

@hannahblair hannahblair merged commit 15c97c6 into main Dec 21, 2023
13 checks passed
@hannahblair hannahblair deleted the fix-webcam-streaming branch December 21, 2023 18:50
@pngwn pngwn mentioned this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webcam stream not showing in 4.11.0
3 participants