New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure camera settings only update when necessary in Model3D #6871
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/27b95ca8f4ac5d643907e910a5f5682379187208/gradio-4.12.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@27b95ca8f4ac5d643907e910a5f5682379187208#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
reset_camera_position
reactivity logicThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great. Nice demo too!
I'll go ahead and merge this in so we can get it out for the release. Thanks @hannahblair |
Description
We were calling
reset_camera_position
whenever the component re-rendered. This isn't ideal if the value, nor camera settings of a scene have changed. However, we need to maintain this reactivity if any of those camera properties do change.This PR checks if the old camera settings are different to the new camera settings before resetting the scene.
A test demo: (where we dynamically change the camera position, and also check that we maintain the camera settings when re-rendering)
Closes: #6859
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh