Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with Webcam Recording #6885

Merged
merged 12 commits into from Jan 6, 2024
Merged

Fix issue with Webcam Recording #6885

merged 12 commits into from Jan 6, 2024

Conversation

dawoodkhan82
Copy link
Collaborator

Description

Fix issue with no video being passed to backend when recording with webcam.

Closes: #6872

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Dec 26, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/9c803754db3471f03e0aa24252ba91f740f83f54/gradio-4.13.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@9c803754db3471f03e0aa24252ba91f740f83f54#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Dec 26, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/image patch
@gradio/imageeditor patch
@gradio/video patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix issue with Webcam Recording

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Collaborator

@aliabid94 aliabid94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, thanks for fixing!

js/image/shared/Webcam.svelte Outdated Show resolved Hide resolved
@dawoodkhan82 dawoodkhan82 merged commit 640b7fe into main Jan 6, 2024
19 of 20 checks passed
@dawoodkhan82 dawoodkhan82 deleted the webcam_recording branch January 6, 2024 00:19
@pngwn pngwn mentioned this pull request Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gr.Video output showing empty
4 participants