Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests for Lite #6890

Merged
merged 18 commits into from Feb 7, 2024
Merged

E2E tests for Lite #6890

merged 18 commits into from Feb 7, 2024

Conversation

whitphx
Copy link
Member

@whitphx whitphx commented Dec 27, 2023

Description

Closes: #6141

The failed tests for Chatbot should be solved with #6897

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Dec 27, 2023

🪼 branch checks and previews

Name Status URL
Spaces building...
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Dec 27, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/app minor
@gradio/tootils minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

E2E tests for Lite

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member

abidlabs commented Feb 2, 2024

@whitphx how are these E2E tests looking?

@whitphx
Copy link
Member Author

whitphx commented Feb 5, 2024

@abidlabs It's still under development. Rebasing the main...

@whitphx whitphx force-pushed the lite-e2e-test branch 3 times, most recently from 303247e to 554c709 Compare February 6, 2024 08:47
Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine to merge, we'll need to merge in order to test.

@hannahblair hannahblair marked this pull request as ready for review February 6, 2024 15:49
@pngwn
Copy link
Member

pngwn commented Feb 6, 2024

I need to fix CI on main to get these visual tests to behave.

@whitphx whitphx enabled auto-merge (squash) February 7, 2024 04:15
@whitphx
Copy link
Member Author

whitphx commented Feb 7, 2024

ok, will merge this while maybe the test won't work soon. Enabled the auto-merge.

@abidlabs abidlabs merged commit cccab27 into main Feb 7, 2024
8 checks passed
@abidlabs abidlabs deleted the lite-e2e-test branch February 7, 2024 07:46
@abidlabs
Copy link
Member

abidlabs commented Feb 7, 2024

CI was being weird, but went ahead and merged it automatically @whitphx!

@pngwn pngwn mentioned this pull request Feb 7, 2024
freddyaboulton pushed a commit that referenced this pull request Feb 9, 2024
* Set up E2E test config for lite

* Use the same Page instance for all the tests in the case of lite

* Fix reading demo files

* Fix config

* Install requirements based on `requirements.txt`

* Add the "loaded" event dispatched from the main component to make a promise wait for the compoonent to be loaded

* Refactor js/tootils/src/index.ts

* Add testIgnore for lite

* Fix chatbot_multimodal.spec.ts

* Stop raising an exception when trying to cache examples but just show warning

* Update comment

* Mark the test slow when the page is initialized in it

* Add logs

* Set timeout

* add changeset

* Add the CI file .github/workflows/test-lite.yml

* Add E2E testing for Lite to the test-functional job

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gradio-lite Related to the @gradio/lite library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lite: E2E tests
4 participants