Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docstring of deprecated parameter concurrency_count #6916

Merged
merged 3 commits into from Jan 2, 2024

Conversation

ronensc
Copy link
Contributor

@ronensc ronensc commented Jan 1, 2024

The old docstring mentioned that it has no effect. Contrary to that, it will raise an exception.

Description

Please include a concise summary, in clear English, of the changes in this pull request. If it closes an issue, please mention it here.

Closes: #(issue)

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

The old docstring mentioned that it has no effect. Contrary to that, it will raise an exception.
@abidlabs
Copy link
Member

abidlabs commented Jan 2, 2024

Fair, thank you @ronensc!

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jan 2, 2024

🪼 branch checks and previews

Name Status URL
🦄 Changes detected! Details

@gradio-pr-bot
Copy link
Contributor

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix docstring of deprecated parameter concurrency_count

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs abidlabs merged commit 02c2442 into gradio-app:main Jan 2, 2024
8 of 15 checks passed
@pngwn pngwn mentioned this pull request Jan 2, 2024
@ronensc ronensc deleted the patch-1 branch January 8, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants