Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display pending file in <Upload /> while waiting for upload request #6969

Merged
merged 4 commits into from Jan 8, 2024

Conversation

hannahblair
Copy link
Collaborator

@hannahblair hannahblair commented Jan 8, 2024

Description

We were waiting for a file upload to have progressed in the network request before showing it as a pending file upload. As a small UX improvement, this PR shows the first file to be uploaded while waiting for the uploading network request to start.

Before:
Kapture 2024-01-08 at 15 24 31

After:
Kapture 2024-01-08 at 15 23 11

Closes: #6968

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jan 8, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/d536d70e357359428b94ef58094fd2ed9f13187d/gradio-4.13.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@d536d70e357359428b94ef58094fd2ed9f13187d#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jan 8, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/upload patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Display pending file in <Upload /> while waiting for upload request

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works more nicely with slow network speeds or large files. Thanks @hannahblair!

@hannahblair hannahblair merged commit 793bf8f into main Jan 8, 2024
20 checks passed
@hannahblair hannahblair deleted the improve-upload-bar branch January 8, 2024 16:36
@pngwn pngwn mentioned this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress bar
3 participants